Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix FDS auto-complete for Conda installs #8698

Merged
merged 2 commits into from Sep 11, 2023

Conversation

Kilo59
Copy link
Member

@Kilo59 Kilo59 commented Sep 11, 2023

Conda packages currently are missing auto-complete for most of our FDS API.
This is because the conda package does not seem to be shipping with our .pyi stub files.

Example context.sources

image

This PR updates the MANIFEST.ini to include all .pyi files.
Updating MANFIEST.ini is not required as part of normal setuptools uploads, but this seems to be required for conda.

The package_data argument is a dictionary that maps from package names to lists of glob patterns. Note that the data files specified using the package_data option neither require to be included within a MANIFEST.in file, nor require to be added by a revision control system plugin.

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 30b9730
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/64ff53d3d66f010008c60248

@github-actions github-actions bot added the core label Sep 11, 2023
@Kilo59 Kilo59 self-assigned this Sep 11, 2023
@ghost
Copy link

ghost commented Sep 11, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Kilo59 Kilo59 requested a review from abegong September 11, 2023 17:25
@Kilo59 Kilo59 merged commit 7f0478a into develop Sep 11, 2023
57 checks passed
@Kilo59 Kilo59 deleted the fix-conda-auto-complete branch September 11, 2023 19:28
@Kilo59 Kilo59 added the dx label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants