Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Clarify How to Use Custom Expectations Without a Filesystem #8700

Merged
merged 6 commits into from Sep 18, 2023
Merged

[DOCS] Clarify How to Use Custom Expectations Without a Filesystem #8700

merged 6 commits into from Sep 18, 2023

Conversation

kwcanuck
Copy link
Contributor

@kwcanuck kwcanuck commented Sep 12, 2023 •
edited by jira bot

In DSB-210, @austiezr requested that we clarify the requirements for using Custom Expectations without a Filesystem Data Context. This PR implements this update.

Definition of done

  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Appropriate tests and docs have been updated

@netlify
Copy link

netlify bot commented Sep 12, 2023 •
edited

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 10d65b6
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6504b279d833820008005771
😎 Deploy Preview https://deploy-preview-8700.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the devrel This item is being addressed by the Developer Relations Team label Sep 12, 2023
@ghost
Copy link

ghost commented Sep 12, 2023 •
edited by ghost

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Rachel-Reverie
Rachel-Reverie approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@Rachel-Reverie Rachel-Reverie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

austiezr
austiezr approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@austiezr austiezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@kwcanuck kwcanuck merged commit 4f3308b into develop Sep 18, 2023
54 checks passed
@kwcanuck kwcanuck deleted the ce-without-filesystem branch September 18, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austiezr austiezr austiezr approved these changes

@Rachel-Reverie Rachel-Reverie Rachel-Reverie approved these changes

Assignees
No one assigned
Labels
devrel This item is being addressed by the Developer Relations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kwcanuck @austiezr @Rachel-Reverie