[BUGFIX] add try except to redshift regexp resolver #8707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
anthonyburdi
approved these changes
Sep 13, 2023
Kilo59
reviewed
Sep 13, 2023
Comment on lines
+99
to
+101
| ) | ||
| else: | ||
| return sqlalchemy.BinaryExpression( | ||
| column, sqlalchemy.literal(regex), sqlalchemy.custom_op("!~") | ||
| ) | ||
| else: | ||
| pass |
There was a problem hiding this comment.
This else should just be removed.
Kilo59
reviewed
Sep 13, 2023
| ) | ||
| else: | ||
| pass | ||
| except AttributeError: |
There was a problem hiding this comment.
@itaise do you have a stracktrace of this exact AttributeError?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added try/except to the part which resolves redshift regexp function.
This is to fix (this issue)[https://github.com//issues/8701]
Can you please check?
thanks a lot!