Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTRIB] Update notify_on_failure to not run on merge_group events #8768

Merged
merged 2 commits into from Sep 27, 2023

Conversation

TrangPham
Copy link
Contributor

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit aa527a1
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65147ff17509910008972431

@TrangPham TrangPham marked this pull request as ready for review September 27, 2023 19:14
Copy link
Member

@Kilo59 Kilo59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Looks like your IDE is autoformatting the YAML again.

The setting below works for me.

    "yaml.format.enable": false,

@ghost
Copy link

ghost commented Sep 27, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@TrangPham TrangPham added this pull request to the merge queue Sep 27, 2023
Merged via the queue into develop with commit da39537 Sep 27, 2023
53 checks passed
@TrangPham TrangPham deleted the update-notify-on-failure branch September 27, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants