[MAINTENANCE] Column Descriptive Metrics: Empty string instead of UNKNOWN if table column type introspection fails #8819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Kilo59
reviewed
Oct 10, 2023
| column_types_converted_to_str: list[dict[str, str]] = [ | ||
| { | ||
| "name": raw_column_type["name"], | ||
| "type": str(raw_column_type.get("type", "UNKNOWN")), | ||
| "type": str(raw_column_type.get("type", "")), |
There was a problem hiding this comment.
Could you leave the type field out?
Although my assumption is that is a required field.
There was a problem hiding this comment.
Currently it's required e.g. https://github.com/greatexpectationslabs/mercury/blob/develop/services/ge_cloud/mercury/handlers/gql/metric.py#L136. I could probably loosen up the endpoint though - I think @donaldheppner was asking about this as well. I'll merge this for now but take a crack first thing tomorrow.
There was a problem hiding this comment.
This PR is for the backend side: https://github.com/greatexpectationslabs/mercury/pull/2364, I'll need a separate PR for OSS.
Kilo59
approved these changes
Oct 10, 2023
Shinnnyshinshin
added a commit
that referenced
this pull request
Oct 12, 2023
…zel-72/test-marker-update-data-assistant-test * m/zel-63/zel-68/add-jupyter-test-marker: (39 commits) [BUGFIX] Fix missing `config_provider` (#8822) [MAINTENANCE] Bump gitpython from 3.1.35 to 3.1.37 in /docs_rtd (#8818) [BUGFIX] Fix Snowflake `'connection_string'` `TestConnectionError` (#8816) [MAINTENANCE] Delete outdated context fixtures (#8809) [BUGFIX] Improve datasource crud (#8773) [MAINTENANCE] Column Descriptive Metrics: Empty string instead of UNKNOWN if table column type introspection fails (#8819) [BUGFIX] Column Descriptive Metrics: Convert table name to lowercase for snowflake (#8817) [BUGFIX] Column Descriptive Metrics: Skip finding semantic type info for UNKNOWN columns (#8815) [MAINTENANCE] Column Descriptive Metrics: Default to UNKNOWN if type is not found (#8810) [MAINTENANCE] Delete legacy `JsonSchemaProfiler` (#8807) [DOCS] Update docs to reference new `gx/` dir instead of `great_expectations/` (#8717) [MAINTENANCE] Bump urllib3 from 1.26.5 to 1.26.17 in /docs_rtd (#8802) [DOCS] Minor Syntax Update (#8806) [CONTRIB] New MulticolumnValuesProductEqualToSingleColumn Expectation (#8799) [CONTRIB] Updates to MulticolumnValuesSumValuesEqualToSingleColumn (#8798) [RELEASE] 0.17.21 (#8805) [MAINTENANCE] Remove `ge_cloud_mode` from `Store` (#8747) [MAINTENANCE] disallow-untyped-decorators (#8788) [DOCS] Add Mermaid plugin to Docusaurus (#8793) [MAINTENANCE] Remove SimpleCheckpoint from public API docs (#8770) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty string instead of UNKNOWN if table column type introspection fails.
Example:
invoke lint(usesblack+ruff)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!