[MAINTENANCE] Typing render/view #8903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bill Dirks <bill.dirks@gmail.com> Co-authored-by: Anthony Burdi <anthonyburdi@users.noreply.github.com> Co-authored-by: T Pham <TrangPham@users.noreply.github.com> Co-authored-by: Chetan Kini <ckini123@gmail.com> Co-authored-by: Nathan Farmer <NathanFarmer@users.noreply.github.com>
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Kilo59
requested review from
NathanFarmer,
billdirks,
anthonyburdi,
TrangPham and
cdkini
Kilo59
commented
Oct 31, 2023
Comment on lines
+83
to
+87
| 'render/renderer/v3/suite_edit_notebook_renderer\.py', # 11 - This is legacy code and will not be typed. | ||
| 'render/renderer/v3/suite_profile_notebook_renderer\.py', # 4 - This is legacy code and will not be typed. | ||
| 'render/renderer/suite_edit_notebook_renderer\.py', # 7 - This is legacy code and will not be typed. | ||
| 'render/renderer/suite_scaffold_notebook_renderer\.py', # 7 - This is legacy code and will not be typed. | ||
| 'render/renderer/datasource_new_notebook_renderer\.py', # 4 - This is legacy code and will not be typed. |
There was a problem hiding this comment.
@NathanFarmer do these look right? Am I missing anything?
There was a problem hiding this comment.
great_expectations/render/renderer/notebook_renderer.py is now typed but should it be deleted when we remove the cli?
There was a problem hiding this comment.
Just missing: render/renderer/checkpoint_new_notebook_renderer.py
There was a problem hiding this comment.
Good catch. Will update both.
There was a problem hiding this comment.
I think notebook_renderer.py will also be removed with the CLI removal. It is the base class for the other notebook renderers.
cdkini
approved these changes
Oct 31, 2023
Shinnnyshinshin
added a commit
that referenced
this pull request
Nov 1, 2023
Shinnnyshinshin
added a commit
that referenced
this pull request
Nov 1, 2023
* develop: [MAINTENANCE] remove deprecated usage of pydantic Extra (#8896) [MAINTENANCE] Better error msg for refrence environments (#8913) [FEATURE] Expect column specified percentile value to be above a given value. (#8907) [DOCS] add 'user' access token clarification to GX Cloud quickstart (#8912) [MAINTENANCE] Typing render/view (#8903) [MAINTENANCE] Adjust timeouts for cloud-tests services (#8910) [DOCS] Update Section Title (#8905) [MAINTENANCE] List checkpoints endpoint contract test (#8886) [MAINTENANCE] Do not skip spark tests in cloud stage (#8901) [MAINTENANCE] Add Expectation Suite Pact tests (#8885) [MAINTENANCE] Get checkpoint endpoint contract test (#8881) [DOCS] Update Cloud Quickstart save expectation suite example (#8893) [RELEASE] 0.18.0 (#8895)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type checking for
render/view/view.pyThis change includes some runtime changes, notable the removal of the
NoOpTemplateand the default_templateclass attribute forDefaultJinjaView