[DOCS] Update Add Validation Data or Expectation Suites to a Checkpoint #8931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
devrel
…ions/great_expectations into validation-update
…_expectations into validation-update
…ions/great_expectations into validation-update
kwcanuck
commented
Nov 16, 2023
.../docs/guides/validation/checkpoints/how_to_add_validations_data_or_suites_to_a_checkpoint.md
Outdated
Show resolved
Hide resolved
kwcanuck
commented
Nov 16, 2023
.../docs/guides/validation/checkpoints/how_to_add_validations_data_or_suites_to_a_checkpoint.md
Outdated
Show resolved
Hide resolved
kwcanuck
commented
Nov 16, 2023
.../docs/guides/validation/checkpoints/how_to_add_validations_data_or_suites_to_a_checkpoint.md
Outdated
Show resolved
Hide resolved
kwcanuck
commented
Nov 16, 2023
.../docs/guides/validation/checkpoints/how_to_add_validations_data_or_suites_to_a_checkpoint.md
Outdated
Show resolved
Hide resolved
kwcanuck
commented
Nov 16, 2023
.../docs/guides/validation/checkpoints/how_to_add_validations_data_or_suites_to_a_checkpoint.md
Outdated
Show resolved
Hide resolved
kwcanuck
commented
Nov 16, 2023
.../docs/guides/validation/checkpoints/how_to_add_validations_data_or_suites_to_a_checkpoint.md
Outdated
Show resolved
Hide resolved
Rachel-Reverie
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
One thing: the PR states that it should include both YAML and python methods for completing the task -- I'm presuming the original description of the PR is outdated, as we've been moving away from YAML based guides (and I didn't see any YAML covered in the updated document or test script). As long as that is the case, then this LGTM.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Force merged after all CI checks passed to enable releasing today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In DSB-408, @donaldheppner requested that the topic Add validation data or Expectation suites to a Checkpoint be updated "... to reflect both YAML and Python-style configuration and brought under test". This PR implements these updates.
Definition of done