Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Databricks shared compute fix #9034

Merged
merged 169 commits into from Dec 14, 2023
Merged

Conversation

jcampbell
Copy link
Member

@jcampbell jcampbell commented Dec 1, 2023

Calls to spark.sparkContext.getConf() fail on a "high concurrency cluster with credential passthrough enabled" due to security concerns. Users can use a different type of cluster, or set spark.databricks.pyspark.enablePy4JSecurity to false, but we don't need to call this method anyway unless we are using a local Spark installation.

This PR also deprecates the use of the force_reuse_spark_context parameter.

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 4836aab
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/656a47a93e0dda0008e47df0
😎 Deploy Preview https://deploy-preview-9034.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NathanFarmer NathanFarmer self-assigned this Dec 1, 2023
@jcampbell jcampbell changed the base branch from develop to 0.18.3 December 1, 2023 22:02
@jcampbell jcampbell changed the title Databricks shared compute fix [BUGFIX] Databricks shared compute fix Dec 1, 2023
@great-expectations great-expectations deleted a comment Dec 1, 2023
@jcampbell jcampbell changed the base branch from 0.18.3 to 0.18.4 December 1, 2023 22:04
@NathanFarmer NathanFarmer added this pull request to the merge queue Dec 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 13, 2023
@NathanFarmer NathanFarmer added this pull request to the merge queue Dec 14, 2023
Merged via the queue into 0.18.x with commit 72ea802 Dec 14, 2023
61 checks passed
@NathanFarmer NathanFarmer deleted the b/_/shared_compute_hotfix branch December 14, 2023 16:55
NathanFarmer added a commit that referenced this pull request Feb 16, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nathan Farmer <nathan@greatexpectations.io>
Co-authored-by: Nathan Farmer <NathanFarmer@users.noreply.github.com>
Co-authored-by: Gabriel <gabriel59kg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants