Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] how_to_connect_to_postgresql_data uses create_temp_table=True #9140

Merged
merged 3 commits into from Dec 19, 2023
Merged

[DOCS] how_to_connect_to_postgresql_data uses create_temp_table=True #9140

merged 3 commits into from Dec 19, 2023

Conversation

Kilo59
Copy link
Member

@Kilo59 Kilo59 commented Dec 19, 2023 •
edited

Needed to unblock the release pipfline.

QueryAsset does not work without create_temp_table=True (the default was changed as part of

@Kilo59 Kilo59 self-assigned this Dec 19, 2023
@ghost
Copy link

ghost commented Dec 19, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

wookasz
wookasz requested changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@wookasz wookasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide context in the PR description on why this change is necessary?

@Kilo59 Kilo59 requested a review from wookasz December 19, 2023 20:09
@Kilo59 Kilo59 changed the title M/ /update docs test [DOCS] how_to_connect_to_postgresql_data uses create_temp_table=True Dec 19, 2023
@Kilo59 Kilo59 added this pull request to the merge queue Dec 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 19, 2023
@Kilo59 Kilo59 added this pull request to the merge queue Dec 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2023
@Kilo59 Kilo59 added this pull request to the merge queue Dec 19, 2023
Merged via the queue into 0.18.x with commit 92a4c03 Dec 19, 2023
62 of 65 checks passed
@Kilo59 Kilo59 deleted the m/_/update_docs_test branch December 19, 2023 22:28
This was referenced Dec 20, 2023
Merged
Merged
Merged
This was referenced Jan 3, 2024
Merged
Merged
This was referenced Jan 10, 2024
Merged
Merged
@cdkini cdkini mentioned this pull request Jan 19, 2024
Merged
4 tasks
@cdkini cdkini mentioned this pull request Feb 1, 2024
Closed
4 tasks
@cdkini cdkini mentioned this pull request Feb 1, 2024
Closed
4 tasks
@cdkini cdkini mentioned this pull request Feb 13, 2024
Closed
4 tasks
This was referenced Feb 27, 2024
Merged
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
@Shinnnyshinshin Shinnnyshinshin mentioned this pull request Mar 19, 2024
Closed
4 tasks
@Shinnnyshinshin Shinnnyshinshin mentioned this pull request Apr 20, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wookasz wookasz wookasz approved these changes

@rreinoldsc rreinoldsc rreinoldsc approved these changes

@roblim roblim Awaiting requested review from roblim

Assignees

@Kilo59 Kilo59

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kilo59 @wookasz @rreinoldsc