[MAINTENANCE] move prepare_prior_versions to allow one version at a time #9246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
tyler-hoffman
changed the title
billdirks
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Amazing what can be simplified by being explicit about versions!
I haven't read this fully yet but have to run a meeting. I'm giving the LGTM since it looks equivalent to me. If there is something you want me to look closely at, let me know.
I realized ignoring whitespace changes made this simpler to review.
| @@ -38,71 +56,21 @@ def change_paths_for_docs_file_references(verbose: bool = False) -> None: | |||
| print(f"Processed {len(files)} files in change_paths_for_docs_file_references") | |||
|
|
|||
|
|
|||
| def _paths_to_versioned_docs() -> list[pathlib.Path]: | |||
There was a problem hiding this comment.
Being able to delete all of these is great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates prepare_prior_versions to allow just building specific versions. This will be used in a new versioning flow (coming in a subsequent PR) It can also be use for backward compatibility in case we need to rebuild v 0.17 or 0.18.
invoke lint(usesblack+ruff)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!