[MAINTENANCE] Rename and move V17 snippets to legacy docs dir #9374
Conversation
for more information, see https://pre-commit.ci
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
for more information, see https://pre-commit.ci
|
todo before this is merged:
|
| @@ -214,60 +214,3 @@ | |||
| context.add_or_update_expectation_suite( | |||
| expectation_suite=test_suite, | |||
| ) | |||
|
|
|||
|
|
|||
| # <snippet name="tests/integration/docusaurus/reference/core_concepts/result_format/result_format_checkpoint_example"> | |||
There was a problem hiding this comment.
this deletion was a manual change - snippet (and rest of file) not used anywhere
There was a problem hiding this comment.
@joshua-stauffer I found that the build failed without this. I think because of files that resulted from invoke api-docs. This part of the process and the gitignored directory are still pretty confusing to me
There was a problem hiding this comment.
wow, okay, great catch!
| @@ -13,7 +13,7 @@ | |||
| ) | |||
|
|
|||
| # Snippet: example data frame for result_format | |||
| # <snippet name="tests/integration/docusaurus/reference/core_concepts/result_format/pandas_df_for_result_format"> | |||
There was a problem hiding this comment.
all changes in this module were manual
This reverts commit 5126943.
This reverts commit 856e8e9.
| @@ -0,0 +1,5 @@ | |||
| Now that you've connected to your data, you'll want to work on these **core skills**: | |||
|
|
|||
| <!-- - [How to create a Batch of data from an in-memory Spark or Pandas dataframe](/docs/guides/connecting_to_your_data/how_to_create_a_batch_of_data_from_an_in_memory_spark_or_pandas_dataframe) --> | |||
There was a problem hiding this comment.
@tyler-hoffman is this the link you commented out? looks like the doc only existed in 0.15
There was a problem hiding this comment.
It did -- this link should have been removed or updated by one of my PRs for the current docs, but at the time that this doc was current the 0.15.x docs were still supported so some links back to them remained for features that didn't have an equivalent any more in 0.17.x.
There was a problem hiding this comment.
I'm pretty sure this entire file was removed in PR 9355
| @@ -19,7 +19,7 @@ To configure a Data Context for a specific environment, see one of the following | |||
|
|
|||
| ## Create Expectation Suites and add Expectations | |||
|
|
|||
| To add a Data Source and an Expectation Suite, see [How to connect to a PostgreSQL database](/guides/connecting_to_your_data/database/connect_sql_source_data.md?sql-database-type=postgresql). | |||
| To add a Data Source and an Expectation Suite, see [How to connect to a PostgreSQL database](/guides/connecting_to_your_data/fluent/database/connect_sql_source_data.md?sql-database-type=postgresql). | |||
There was a problem hiding this comment.
this change surprises me - was it broken before? or did we move the file?
There was a problem hiding this comment.
The original link points to a block-config version of the same content, I believe. Pretty sure it will end up redirecting to the 0.15.x docs, since that content wasn't pulled forward into the more recent versions. The fluent link is correct.
invoke lint(usesblack+ruff)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!