Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update terminal and code snippets style #9419

Merged
merged 10 commits into from Mar 1, 2024

Conversation

JessSaavedra
Copy link
Contributor

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit b4e1d12
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65e23318d402b80008eca1de
😎 Deploy Preview https://deploy-preview-9419.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Feb 9, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@JessSaavedra JessSaavedra force-pushed the DSB-665_update_terminal_and_code_snippets_style branch from 4a1ff95 to 5a8d8f5 Compare February 9, 2024 14:41
@JessSaavedra JessSaavedra force-pushed the DSB-665_update_terminal_and_code_snippets_style branch 6 times, most recently from 12b9dc7 to 43a7d74 Compare February 28, 2024 21:30
Copy link
Member

@josectobar josectobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. I just have a small comment, let me know if it's possible.

docs/docusaurus/src/css/code_block.scss Outdated Show resolved Hide resolved
@JessSaavedra JessSaavedra force-pushed the DSB-665_update_terminal_and_code_snippets_style branch from 2def26c to b4e1d12 Compare March 1, 2024 19:57
Copy link
Member

@josectobar josectobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 👍🏽

@JessSaavedra JessSaavedra added this pull request to the merge queue Mar 1, 2024
Merged via the queue into develop with commit f56fd3d Mar 1, 2024
62 checks passed
@JessSaavedra JessSaavedra deleted the DSB-665_update_terminal_and_code_snippets_style branch March 1, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants