Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Was This Helpful section #9426

Merged
merged 20 commits into from Feb 23, 2024
Merged

Conversation

deborahniesz
Copy link
Contributor

@deborahniesz deborahniesz commented Feb 9, 2024

Description

Deploy Preview
And Here is the Posthog dashboard where we can trace users' anwers

Adding a "Was This Helpful?" Section under every page except the homepage and overview pages.

WasThisHelpfilSection.mp4

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit b2efbd9
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65d8be48e269be000808b100
😎 Deploy Preview https://deploy-preview-9426.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Feb 9, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Member

@josectobar josectobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I think we still want to consider a couple of things we discussed today before merging this PR. Changing the thumbs up or down with something else, showing a different state after they click and adding this posthog key env variable during the CI job. I can add the key to the Github secrets. cc @joshzzheng

docs/docusaurus/src/components/WasThisHelpful/index.js Outdated Show resolved Hide resolved
@deborahniesz deborahniesz force-pushed the DSB-668_was_this_helpful_section branch 2 times, most recently from 811c6ad to e32c7f1 Compare February 21, 2024 14:54
josectobar

This comment was marked as duplicate.

josectobar

This comment was marked as duplicate.

@josectobar
Copy link
Member

I haven't seen the latest designs but the padding feels a little weird. @SuperYeehee
image

@SuperYeehee
Copy link

SuperYeehee commented Feb 21, 2024

I haven't seen the latest designs but the padding feels a little weird. @SuperYeehee image

Yes this is the latest design, I don't feel strongly on the padding since that component is centered within the page. I feel that if the padding was lower it would feel like our card components for overview pages.

@josectobar
Copy link
Member

@deborahniesz, there are a few minor changes we should adjust but it's close to done.

Copy link
Member

@josectobar josectobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like I meant to submit these other comments but never did :D

@deborahniesz deborahniesz force-pushed the DSB-668_was_this_helpful_section branch from 4a2db05 to 3aa54e1 Compare February 23, 2024 15:41
Copy link
Member

@josectobar josectobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@deborahniesz deborahniesz added this pull request to the merge queue Feb 23, 2024
Merged via the queue into develop with commit 362393d Feb 23, 2024
62 checks passed
@deborahniesz deborahniesz deleted the DSB-668_was_this_helpful_section branch February 23, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants