New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Was This Helpful section #9426
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, I think we still want to consider a couple of things we discussed today before merging this PR. Changing the thumbs up or down with something else, showing a different state after they click and adding this posthog key env variable during the CI job. I can add the key to the Github secrets. cc @joshzzheng
811c6ad
to
e32c7f1
Compare
I haven't seen the latest designs but the padding feels a little weird. @SuperYeehee |
Yes this is the latest design, I don't feel strongly on the padding since that component is centered within the page. I feel that if the padding was lower it would feel like our card components for overview pages. |
@deborahniesz, there are a few minor changes we should adjust but it's close to done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like I meant to submit these other comments but never did :D
…tomization of default pages to include the component.
…aurus app locally
…ing locally won't have to change anything unless they want to work with posthog
4a2db05
to
3aa54e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
Description
Deploy Preview
And Here is the Posthog dashboard where we can trace users' anwers
Adding a "Was This Helpful?" Section under every page except the homepage and overview pages.
WasThisHelpfilSection.mp4
invoke lint
(usesblack
+ruff
)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!