[BUGFIX] - Prevent duplicate Expectations in Validation Results when Exceptions are triggered #9456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josectobar
force-pushed
the
f/PP-918-running-a-validation-with-one-expectation-can-fail-silently-and-produce-multiple-validation-resultstable-name-custom-renderer-comments
branch
from
70ee096
to
bafd09c
Compare
✅ Deploy Preview for niobium-lead-7998 canceled.
|
josectobar
force-pushed
the
f/PP-918-running-a-validation-with-one-expectation-can-fail-silently-and-produce-multiple-validation-resultstable-name-custom-renderer-comments
branch
from
bafd09c
to
ac7fed1
Compare
for more information, see https://pre-commit.ci
…th-one-expectation-can-fail-silently-and-produce-multiple-validation-resultstable-name-custom-renderer-comments' into f/PP-918-running-a-validation-with-one-expectation-can-fail-silently-and-produce-multiple-validation-resultstable-name-custom-renderer-comments
for more information, see https://pre-commit.ci
…th-one-expectation-can-fail-silently-and-produce-multiple-validation-resultstable-name-custom-renderer-comments' into f/PP-918-running-a-validation-with-one-expectation-can-fail-silently-and-produce-multiple-validation-resultstable-name-custom-renderer-comments
…tions into f/PP-918-running-a-validation-with-one-expectation-can-fail-silently-and-produce-multiple-validation-resultstable-name-custom-renderer-comments
NathanFarmer
approved these changes
Feb 22, 2024
…pectation-can-fail-silently-and-produce-multiple-validation-resultstable-name-custom-renderer-comments
…th-one-expectation-can-fail-silently-and-produce-multiple-validation-resultstable-name-custom-renderer-comments' into f/PP-918-running-a-validation-with-one-expectation-can-fail-silently-and-produce-multiple-validation-resultstable-name-custom-renderer-comments
…tions into f/PP-918-running-a-validation-with-one-expectation-can-fail-silently-and-produce-multiple-validation-resultstable-name-custom-renderer-comments
josectobar
deleted the
f/PP-918-running-a-validation-with-one-expectation-can-fail-silently-and-produce-multiple-validation-resultstable-name-custom-renderer-comments
branch
josectobar
added a commit
that referenced
this pull request
Feb 26, 2024
…Exceptions are triggered (#9456)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where duplicate Expectation in a Expectation Validation Result were getting added when error exceptions were captured. This was being caused when the
aborted_exception_infowas getting duplicated on retry (3x for each retry).Changes:
Only one error is capture on every retry, overwriting the previous one.
A dictionary with the metric id as string key and an exception is added into an Expectation Validation Result instead of adding an EVR for each exception.
Description of PR changes above includes a link to an existing GitHub issue
PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
Code is linted - run
invoke lint(usesblack+ruff)Appropriate tests and docs have been updated
For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!