[MAINTENANCE] Ensure that DataContextConfig has a consistent shape when args are omitted
#9469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cdkini
commented
Feb 15, 2024
Comment on lines
-2376
to
-2382
| if checkpoint_store_name is not None: | ||
| self.checkpoint_store_name = checkpoint_store_name | ||
| if profiler_store_name is not None: | ||
| self.profiler_store_name = profiler_store_name | ||
| self.checkpoint_store_name = checkpoint_store_name | ||
| self.profiler_store_name = profiler_store_name | ||
| self.plugins_directory = plugins_directory | ||
| if validation_operators is not None: | ||
| self.validation_operators = validation_operators |
There was a problem hiding this comment.
These feel bad. I shouldn't have the reason about whether or not an object has an attr. Shape should be consistent (even if values are not!)
cdkini
deleted the
m/_/update_context_config_to_have_uniform_properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shape of the object should always be the same - we shouldn't conditionally set attrs but rather just use defaults or Nones
invoke lint(usesblack+ruff)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!