Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Misconfigured Expectations affecting unassociated Checkpoints #9491

Merged
merged 12 commits into from Mar 5, 2024
Merged

[BUGFIX] Misconfigured Expectations affecting unassociated Checkpoints #9491

merged 12 commits into from Mar 5, 2024

Conversation

NathanFarmer
Copy link
Contributor

Cherry-picked from: #9431

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

@NathanFarmer @cdkini
[BUGFIX] Misconfigured Expectations affecting unassociated Checkpoints (
b7d44b5 
#9431)

Co-authored-by: Chetan Kini <chetan@superconductive.com>
@NathanFarmer NathanFarmer self-assigned this Feb 16, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 16, 2024 •
edited

✅ Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 1eab00e
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65e72bf14c9261000742a657

@NathanFarmer NathanFarmer marked this pull request as draft February 16, 2024 21:48
@ghost
Copy link

ghost commented Feb 16, 2024 •
edited by ghost

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

NathanFarmer
NathanFarmer commented Feb 17, 2024
View reviewed changes
tests/core/test_util.py
@@ -11,9 +12,10 @@
)


@freeze_time("11/05/1955")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was failing python 3.11 on 0.18.x

@NathanFarmer NathanFarmer marked this pull request as ready for review February 17, 2024 01:04
@NathanFarmer NathanFarmer added this pull request to the merge queue Mar 5, 2024
Merged via the queue into develop with commit 3c13218 Mar 5, 2024
67 checks passed
@NathanFarmer NathanFarmer deleted the b/PP-1184/invalid-expectation-configs-break-everything-develop branch March 5, 2024 15:19
deborahniesz pushed a commit that referenced this pull request Mar 12, 2024
@NathanFarmer @cdkini @deborahniesz
[BUGFIX] Misconfigured Expectations affecting unassociated Checkpoints (
84685d6 
#9491)

Co-authored-by: Chetan Kini <chetan@superconductive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kilo59 Kilo59 Kilo59 approved these changes

@tyler-hoffman tyler-hoffman Awaiting requested review from tyler-hoffman

@cdkini cdkini Awaiting requested review from cdkini

Assignees

@NathanFarmer NathanFarmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NathanFarmer @Kilo59