Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix test setup to get ephemeral context #9504

Merged
merged 1 commit into from Feb 21, 2024

Conversation

tyler-hoffman
Copy link
Contributor

Fixes the failure seen here: https://github.com/great-expectations/great_expectations/actions/runs/7988746346/job/21814183950#step:5:233. I suspect there are other underlying issues with sharing context between tests, but following the error from CI makes it look like in this case, just forcing an ephemeral context does the trick.

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 328d3f2
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65d60559b7acb00008493e5d

@ghost
Copy link

ghost commented Feb 21, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@tyler-hoffman tyler-hoffman added this pull request to the merge queue Feb 21, 2024
Merged via the queue into develop with commit bd6e983 Feb 21, 2024
68 checks passed
@tyler-hoffman tyler-hoffman deleted the m/fix-test-setup branch February 21, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants