[MAINTENANCE] Rename ge_cloud_id to id
#9529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
cdkini
commented
Feb 26, 2024
Comment on lines
+216
to
+218
| # Temporary fork to account for pre-V1 configs | ||
| if "ge_cloud_id" in suite_kwargs and "id" not in suite_kwargs: | ||
| suite_kwargs["id"] = suite_kwargs.pop("ge_cloud_id") |
There was a problem hiding this comment.
Added this to get E2E tests passing - should we just xfail instead?
There was a problem hiding this comment.
Is the e3e test interacting with cloud or with file-based context? if cloud, I'd say what you have here is good, and we should just create a small ticket to track cleaning this up.
There was a problem hiding this comment.
i think this is worth it to maintain test coverage
great_expectations/data_context/data_context/abstract_data_context.py
Outdated
Show resolved
Hide resolved
tyler-hoffman
approved these changes
Feb 26, 2024
joshua-stauffer
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invoke lint(usesblack+ruff)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!