Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Sample getting a file passing mdx check #9532

Merged
merged 2 commits into from Feb 26, 2024

Conversation

tyler-hoffman
Copy link
Contributor

Looks like the mdx checker is happy as long as <summary> isn't on the same line as <details>. I don't understand why ATM.

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit aab8c97
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65dcbb1eccf2750008d2b86d
😎 Deploy Preview https://deploy-preview-9532.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -42,13 +42,14 @@ You can add an Expectation Suite to your Data Context at the same time as you cr

:::

<details><summary>Full example code</summary>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a few things. This first change is structured differently than the rest, and both seem to pass.

@tyler-hoffman tyler-hoffman added this pull request to the merge queue Feb 26, 2024
@tyler-hoffman tyler-hoffman removed this pull request from the merge queue due to a manual request Feb 26, 2024
@tyler-hoffman tyler-hoffman added this pull request to the merge queue Feb 26, 2024
Merged via the queue into develop with commit 38a6489 Feb 26, 2024
63 checks passed
@tyler-hoffman tyler-hoffman deleted the m/_/get_a_file_passing_mdx_check branch February 26, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants