Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Improve typing and comment #9534

Merged
merged 3 commits into from Feb 26, 2024

Conversation

josectobar
Copy link
Member

Adding changes made in 0.18.x branch

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link
Contributor

@NathanFarmer NathanFarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you already merged the new logic?

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 5cdcb8d
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65dce2a8339d090008300dea

@josectobar josectobar changed the title [Maintenance] Improve typing and comment [MAINTENANCE] Improve typing and comment Feb 26, 2024
@josectobar
Copy link
Member Author

I guess you already merged the new logic?

Yes

@josectobar josectobar added this pull request to the merge queue Feb 26, 2024
Merged via the queue into develop with commit ccefa47 Feb 26, 2024
67 of 68 checks passed
@josectobar josectobar deleted the f/add-comment-improve-typing branch February 26, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants