[DOCS] Hide duplicate tabs #9570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
josectobar
reviewed
Mar 6, 2024
| @@ -8,6 +8,10 @@ div[role="tabpanel"]{ | |||
| font-weight: var(--ifm-font-weight-normal); | |||
| line-height: var(--p-line-height); | |||
|
|
|||
| &.hidden { | |||
There was a problem hiding this comment.
Are we going to need to add this class to each screen in order to get this effect?
There was a problem hiding this comment.
My understanding is that we'll add the class name to any Tab group that we want to hide the tab selection portion of.
There was a problem hiding this comment.
Rachel is right, any tab that has the hidden class in the markdown will be hidden!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If
className="hidden"is added to a Tabs component, it will have its tabs hidden (useful for nested tabs inside the same document that will always have the same value).You can check this does not break the logic of switching tabs, there's an example in this page: https://deploy-preview-9570.docs.greatexpectations.io/docs/oss/guides/setup/installation/install_gx. If you select
piporcondatabs inside thelocaltab, you will see the content is updated properly, even though the second set of tabs that previously showed optionspipandcondaagain is hidden.Screenshots
Before
After
invoke lint(usesblack+ruff)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!