Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Removes remaining OSS docs from the prerelease version #9582

Merged

Conversation

Rachel-Reverie
Copy link
Contributor

Description

Removes remaining OSS docs from the prerelease folder

Definition of done

  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 9dba79f
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65ef42cb6ab9ff000847bead
😎 Deploy Preview https://deploy-preview-9582.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@kwcanuck kwcanuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion we should not publish the 1.0 docs until they are ready, or more complete. I don't think incomplete documentation with under construction icons is helpful or presents the right image. However, it's not my call.

…release_docs

# Conflicts:
#	docs/docusaurus/docs/oss/deployment_patterns/how_to_use_gx_with_aws/components/_datasource_code_environment.md
#	docs/docusaurus/docs/oss/guides/connecting_to_your_data/fluent/filesystem/connect_filesystem_source_data.md
#	docs/docusaurus/docs/oss/guides/expectations/how_to_create_and_edit_expectations_with_instant_feedback_from_a_sample_batch_of_data.md
#	docs/docusaurus/docs/oss/guides/expectations/how_to_edit_an_existing_expectationsuite.md
#	docs/docusaurus/docs/oss/guides/setup/installation/components_local/_install_great_expectations.mdx
#	docs/docusaurus/docs/oss/team_templates/how_to_template.md
#	docs/docusaurus/docs/oss/team_templates/tutorial_template.md
#	tests/integration/test_script_runner.py
@Rachel-Reverie Rachel-Reverie added this pull request to the merge queue Mar 11, 2024
Merged via the queue into develop with commit 3f65ae3 Mar 11, 2024
67 checks passed
@Rachel-Reverie Rachel-Reverie deleted the d/docs/remove_remaining_oss_docs_from_prerelease_docs branch March 11, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants