Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update Account Identifier Field Description #9583

Merged
merged 5 commits into from Mar 7, 2024

Conversation

kwcanuck
Copy link
Contributor

@kwcanuck kwcanuck commented Mar 7, 2024

In the the GX Cloud topic, Create a Snowflake Data Asset the description for the Account identifier field required clarification of the expected entry formats. In addition, the documentation links needed refinement and updating. This PR implements these changes.

Definition of done

  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Appropriate tests and docs have been updated

Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit dd67baa
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65e9d849326be90008682e27
😎 Deploy Preview https://deploy-preview-9583.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Rachel-Reverie Rachel-Reverie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor suggestion; if you accept it then it should be applied to all of the edits.

kwcanuck and others added 2 commits March 7, 2024 10:04
Co-authored-by: Rachel-Reverie <94694058+Rachel-Reverie@users.noreply.github.com>
@kwcanuck kwcanuck added this pull request to the merge queue Mar 7, 2024
Merged via the queue into develop with commit 9b045be Mar 7, 2024
56 checks passed
@kwcanuck kwcanuck deleted the account-identifier-update branch March 7, 2024 15:43
deborahniesz pushed a commit that referenced this pull request Mar 12, 2024
Co-authored-by: Rachel-Reverie <94694058+Rachel-Reverie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants