Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Revise OSS Installation and Setup Guidance for Google Cloud Storage #9600

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

kwcanuck
Copy link
Contributor

@kwcanuck kwcanuck commented Mar 11, 2024

DOC-685 requests a review and edit of the existing content in the GCS section of Install Great Expectations with source data system dependencies. This PR implements the necessary edits for 1.0.

Definition of done

  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 1236537
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65ef1ee2d00c0f0008280f13
😎 Deploy Preview https://deploy-preview-9600.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Rachel-Reverie Rachel-Reverie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- in the ToC you can remove the little "under construction" icon from the link to these pages.

@kwcanuck kwcanuck added this pull request to the merge queue Mar 11, 2024
Merged via the queue into develop with commit 845d2c5 Mar 11, 2024
62 checks passed
@kwcanuck kwcanuck deleted the gcs-revision branch March 11, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants