Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Refactor ColumnDescriptiveMetricsMetricRetriever to parent class (develop) #9614

Conversation

Shinnnyshinshin
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin commented Mar 12, 2024

Same changes as #9612, but into the develop branch

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@Shinnnyshinshin Shinnnyshinshin changed the title [MAINTENANCE] [MAINTENANCE] Refactor ColumnDescriptiveMetricsMetricRetriever to parent class (0.18.x) #9612 [MAINTENANCE] [MAINTENANCE] Refactor ColumnDescriptiveMetricsMetricRetriever to parent class (develop) Mar 12, 2024
Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit e77ad61
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65f0bcd70114b50008fd14b2

@Shinnnyshinshin Shinnnyshinshin changed the title [MAINTENANCE] [MAINTENANCE] Refactor ColumnDescriptiveMetricsMetricRetriever to parent class (develop) [MAINTENANCE] Refactor ColumnDescriptiveMetricsMetricRetriever to parent class (develop) Mar 12, 2024
@Shinnnyshinshin Shinnnyshinshin self-assigned this Mar 12, 2024
@Shinnnyshinshin Shinnnyshinshin added this pull request to the merge queue Mar 12, 2024
Merged via the queue into develop with commit c06a77c Mar 12, 2024
70 checks passed
@Shinnnyshinshin Shinnnyshinshin deleted the f/zel-455/zel-488/cdm-code-moved-to-parent-class-develop branch March 12, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants