[BUGFIX] Remove counts when showing a sample #9638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
…t-accurate-v1' into b/zel-559/dont-show-counts-if-not-accurate-v1
anthonyburdi
commented
Mar 21, 2024
great_expectations/render/util.py
Outdated
Comment on lines
272
to
302
| table_rows.append(["null", count]) | ||
| # Since accurate counts for the full dataset are not available, we show Sampled Unexpected Values only. | ||
| table_rows.append([value]) |
There was a problem hiding this comment.
This is the main change, removing the count from the table.
anthonyburdi
commented
Mar 21, 2024
| if all_unexpected_in_samples: | ||
| header_row = ["Unexpected Value", "Count"] | ||
| else: | ||
| header_row = ["Sampled Unexpected Values"] |
There was a problem hiding this comment.
We also remove "Count" from the header (otherwise an empty column would render).
Comment on lines
+244
to
+249
| def _get_value_to_render(value_: Any) -> Any: | ||
| if value_ is not None and value_ != "": | ||
| return value_ | ||
| if value_ == "": | ||
| return "EMPTY" | ||
| return "null" |
Shinnnyshinshin
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
I think this is a big improvement in clarity of messaging. Thank you for adding the helper methods, and for pushing through this update @anthonyburdi 🙇🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When showing a sample of data in data docs, the unexpected list now no longer shows a count. The count was the number of times the value showed up in the sample, not in the entire dataset. This was confusing to users, prompting this change.
A sample of data is shown for the unexpected values when the data is too large to display in total and a result format other than
COMPLETEis selected.Image showing the count column that is removed by this PR when showing a sample:
invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!