Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Revises the guidance under the 1.0 prerelease Manage Expectation topic #9639

Merged
merged 18 commits into from
Mar 22, 2024
Merged

[DOCS] Revises the guidance under the 1.0 prerelease Manage Expectation topic #9639

merged 18 commits into from
Mar 22, 2024

Conversation

Rachel-Reverie
Copy link
Contributor

@Rachel-Reverie Rachel-Reverie commented Mar 19, 2024 •
edited
Loading

Description

  • Drafts guidance that employs fewer and less verbose code snippets.

Notes

This doc is in progress; code examples need to be updated and put under test as 1.0 work progresses.

Definition of done

  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]

@netlify Netlify
Copy link

netlify bot commented Mar 19, 2024 •
edited
Loading

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit dd58b93
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65fd9cdb95d53d00088d38f6
😎 Deploy Preview https://deploy-preview-9639.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Rachel-Reverie and others added 15 commits March 19, 2024 10:16
@Rachel-Reverie
Updates prerequisites
2bc13db
@Rachel-Reverie
Revised version using code highlighting over snippets
0e7a536
@Rachel-Reverie
Revised version using tabs to reduce page bloat from long code samples.
45f3402
@Rachel-Reverie
Adds line numbers to full code examples.
7679936
@Rachel-Reverie
Reverts full code example block titles to remove redundancy of "examp…
3a4c023 
…le code"
@Rachel-Reverie
Adds code snippets back into the Procedure tabs; changes the "Example…
8d5493c 
… code" labels to "Sample code"
@Rachel-Reverie
Fixes inconsistent colon usage; updates GX in installation prereq to …
c4a2e8d 
…GX 1.0 -- will automate the version number to be the most recent release once 1.0 is out instead of 0.18.x being our latest stable version.
@Rachel-Reverie
Adds an optional step to test the modified Expectation to the "Modify…
61697b3 
… an Expectation" topic.
@Rachel-Reverie
Updates the format for the Manage Expectation Suites topic; adds some…
1cecf30 
… template and prerequisite snippets.
@Rachel-Reverie
Merge branch 'develop' into d/less_verbose_guidance
9181825
@Rachel-Reverie
Revises example code and link
5ee8596
@Rachel-Reverie
Standardizes prereq format (no ending punctuation so that they can be…
4c3c624 
… expanded with topic specific caveats), revises Manage Expectation Suites example code.
@Rachel-Reverie
Enables line numbers on full example code blocks
4ac07ec
@Rachel-Reverie
Revises "Manage Expectation Suites" per suggestions from Slack. Creat…
869d55b 
…es a "common steps" imporatable tag for "Request a Data context"
@Rachel-Reverie
Merge branch 'develop' into d/less_verbose_guidance
18c0154
@Rachel-Reverie Rachel-Reverie added this pull request to the merge queue Mar 22, 2024
Merged via the queue into develop with commit 9422f0c Mar 22, 2024
63 checks passed
@Rachel-Reverie Rachel-Reverie deleted the d/less_verbose_guidance branch March 22, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwcanuck kwcanuck kwcanuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rachel-Reverie @kwcanuck