Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Rename batch_definition_options to batch_parameters #9653

Merged
merged 1 commit into from
Mar 22, 2024
Merged

[MAINTENANCE] Rename batch_definition_options to batch_parameters #9653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion great_expectations/checkpoint/v1_checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def _run_validation_definitions(
run_results: Dict[ValidationResultIdentifier, ExpectationSuiteValidationResult] = {}
for validation_definition in self.validation_definitions:
validation_result = validation_definition.run(
batch_definition_options=batch_parameters,
batch_parameters=batch_parameters,
evaluation_parameters=expectation_parameters,
result_format=result_format,
)
Expand Down
4 changes: 2 additions & 2 deletions great_expectations/core/validation_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,13 +199,13 @@ def _decode_data(cls, data_dict: dict) -> BatchConfig:
def run(
self,
*,
batch_definition_options: Optional[BatchRequestOptions] = None,
batch_parameters: Optional[BatchRequestOptions] = None,
evaluation_parameters: Optional[dict[str, Any]] = None,
result_format: ResultFormat = ResultFormat.SUMMARY,
) -> ExpectationSuiteValidationResult:
validator = Validator(
batch_config=self.batch_definition,
batch_request_options=batch_definition_options,
batch_request_options=batch_parameters,
result_format=result_format,
)
results = validator.validate_expectation_suite(self.suite, evaluation_parameters)
Expand Down
2 changes: 1 addition & 1 deletion tests/checkpoint/test_v1_checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ def test_checkpoint_run_passes_through_runtime_params(
)

validation_definition.run.assert_called_with(
batch_definition_options=batch_parameters,
batch_parameters=batch_parameters,
evaluation_parameters=expectation_parameters,
result_format=ResultFormat.SUMMARY,
)
Expand Down
2 changes: 1 addition & 1 deletion tests/core/test_validation_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def test_passes_complex_data_to_validator(
mock_validator.graph_validate.return_value = [ExpectationValidationResult(success=True)]

validation_config.run(
batch_definition_options={"year": 2024},
batch_parameters={"year": 2024},
evaluation_parameters={"max_value": 9000},
result_format=ResultFormat.COMPLETE,
)
Expand Down