[FEATURE] Checkpoint.save()
#9676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9676 +/- ##
========================================
Coverage 82.55% 82.55%
========================================
Files 511 511
Lines 46381 46395 +14
========================================
+ Hits 38288 38301 +13
- Misses 8093 8094 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| try: | ||
| store.update(key=key, value=self) | ||
| except gx_exceptions.StoreBackendError as e: | ||
| raise ValueError(f"Could not find existing Checkpoint '{self.name}' to update") from e |
There was a problem hiding this comment.
I think this error is too specific - for instance, if the cloud handler returns a 400 due to a field of an unexpected type.
There was a problem hiding this comment.
Hmm what error do we want to catch then? The other domain objects don't do error handling here but I don't want to raise a store backend error to the user (feels like that is more internal?)
| @@ -21,9 +18,8 @@ | |||
|
|
|||
| # TODO: Add analytics as needed | |||
| class CheckpointFactory(Factory[Checkpoint]): | |||
| def __init__(self, store: CheckpointStore, context: AbstractDataContext): | |||
joshua-stauffer
requested changes
Mar 28, 2024
Comment on lines
301
to
303
| except gx_exceptions.StoreBackendError as e: | ||
| name = key.to_tuple()[0] | ||
| raise ValueError(f"Could not find existing Checkpoint '{name}' to update") from e |
There was a problem hiding this comment.
isn't this the same issue as before? There are other valid errors -- such as validation -- Cloud backend can throw, so this error message is too specific.
joshua-stauffer
requested changes
Apr 1, 2024
joshua-stauffer
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!