Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Corrects broken import for prerequisites in v0.18 connect to Filesystem Data Assets page #9679

Merged

Conversation

Rachel-Reverie
Copy link
Contributor

Description

  • Replaces a broken import in the Connect to Filesystem Data Assets topic with a direct link.

Definition of done

  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Appropriate tests and docs have been updated

Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 180b3b2
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/660ad4def55c270008fbbdd0
😎 Deploy Preview https://deploy-preview-9679.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.55%. Comparing base (200c968) to head (180b3b2).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9679   +/-   ##
========================================
  Coverage    82.55%   82.55%           
========================================
  Files          511      511           
  Lines        46381    46381           
========================================
+ Hits         38288    38289    +1     
+ Misses        8093     8092    -1     
Flag Coverage Δ
3.10 64.60% <ø> (ø)
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 spark ?
3.10 trino ?
3.11 64.60% <ø> (+<0.01%) ⬆️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.98% <ø> (ø)
3.11 aws_deps 48.99% <ø> (ø)
3.11 big 64.00% <ø> (ø)
3.11 databricks 48.21% <ø> (ø)
3.11 filesystem 63.78% <ø> (-0.01%) ⬇️
3.11 mssql 47.43% <ø> (ø)
3.11 mysql 47.48% <ø> (ø)
3.11 postgresql 54.27% <ø> (ø)
3.11 snowflake 48.74% <ø> (+<0.01%) ⬆️
3.11 spark 60.66% <ø> (ø)
3.11 trino 53.90% <ø> (ø)
3.8 64.61% <ø> (ø)
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.98% <ø> (ø)
3.8 aws_deps 49.00% <ø> (ø)
3.8 big 64.00% <ø> (ø)
3.8 databricks 48.23% <ø> (ø)
3.8 filesystem 63.79% <ø> (-0.01%) ⬇️
3.8 mssql 47.41% <ø> (ø)
3.8 mysql 47.47% <ø> (ø)
3.8 postgresql 54.26% <ø> (ø)
3.8 snowflake 48.76% <ø> (+<0.01%) ⬆️
3.8 spark 60.62% <ø> (ø)
3.8 trino 53.89% <ø> (ø)
3.9 64.61% <ø> (ø)
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 spark ?
3.9 trino ?
cloud 0.00% <ø> (ø)
docs-basic 54.50% <ø> (ø)
docs-creds-needed 55.07% <ø> (ø)
docs-spark 54.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kwcanuck kwcanuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to implement or ignore the suggested edit.

Rachel-Reverie and others added 2 commits April 1, 2024 10:37
…ing_to_your_data/fluent/filesystem/connect_filesystem_source_data.md

Co-authored-by: Rob Gray <104205257+kwcanuck@users.noreply.github.com>
…ing_to_your_data/fluent/filesystem/connect_filesystem_source_data.md

Co-authored-by: Rob Gray <104205257+kwcanuck@users.noreply.github.com>
@Rachel-Reverie Rachel-Reverie added this pull request to the merge queue Apr 1, 2024
Merged via the queue into develop with commit ff5cc98 Apr 1, 2024
213 checks passed
@Rachel-Reverie Rachel-Reverie deleted the d/doc-696/fix_broken_import_link_in_versioned_docs branch April 1, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants