[FEATURE] Implement TupleFilesystemStoreBackend::get_all #9687
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9687 +/- ##
===========================================
- Coverage 82.55% 82.55% -0.01%
===========================================
Files 511 511
Lines 46437 46439 +2
===========================================
+ Hits 38335 38336 +1
- Misses 8102 8103 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -316,7 +316,8 @@ def _get(self, key): | |||
|
|
|||
| @override | |||
| def _get_all(self) -> list[Any]: | |||
| raise NotImplementedError | |||
| keys = [key for key in self.list_keys() if key != StoreBackend.STORE_BACKEND_ID_KEY] | |||
There was a problem hiding this comment.
Feels weird to have to exclude this myself. Is there a better option?
There was a problem hiding this comment.
It is getting reported correctly (eventually) but codecov begins commenting/reporting immediately.
https://app.codecov.io/gh/great-expectations/great_expectations/pull/9687/blob/great_expectations/data_context/store/tuple_store_backend.py
https://docs.codecov.com/docs/pull-request-comments#after_n_builds
By default Codecov will post and/or update the pull request comment after it processes each report uploaded for a particular pull request commit. If your CI process uploads many reports to codecov, this can be confusing for team members viewing the pull request as reports are processing.
To remedy this, you can delay the posting of a pull request comment until a certain number of reports are received and processed by Codecov, using the after_n_builds setting.
…oreBackend-get_all
invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!