[FEATURE] Implement TupleS3StoreBackend::get_all #9692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9692 +/- ##
========================================
Coverage 82.55% 82.55%
========================================
Files 511 511
Lines 46437 46444 +7
========================================
+ Hits 38335 38342 +7
Misses 8102 8102
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tyler-hoffman
changed the title
tyler-hoffman
commented
Apr 2, 2024
| @@ -560,10 +572,6 @@ def _get(self, key): | |||
| .decode(s3_response_object.get("ContentEncoding", "utf-8")) | |||
| ) | |||
|
|
|||
| @override | |||
There was a problem hiding this comment.
Moved up to be with its friend _get
cdkini
reviewed
Apr 2, 2024
| @@ -543,13 +543,25 @@ def _build_s3_object_key(self, key): | |||
| return s3_object_key | |||
|
|
|||
| def _get(self, key): | |||
| client = self._create_client() | |||
There was a problem hiding this comment.
Hmm do we not create this during init?
cdkini
reviewed
Apr 2, 2024
| @override | ||
| def _get_all(self) -> list[Any]: | ||
| """Get all objects from the store. | ||
| NOTE: This is non-performant because we download each object separately. |
There was a problem hiding this comment.
Is there any reference to docs/code we can put here?
There was a problem hiding this comment.
good call. Updated.
cdkini
approved these changes
Apr 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title. This is query is non-performant because
bucket.objectsonly exposes methods to get ObjectSummaries, rather than the objects themselves. Here are the docs: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3/bucket/objects.html#objects.invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!