[BUGFIX] Ensure that Checkpoint deserializes proper action subclass
#9701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
cdkini
commented
Apr 3, 2024
| ids=[k.__name__ for k in ACTION_INIT_PARAMS], | ||
| ) | ||
| @pytest.mark.unit | ||
| def test_action_deserialization_within_parent_class( |
There was a problem hiding this comment.
Now that we can test this with Checkpoint, I'd like to remove this test
| def test_checkpoint_deserialization_with_actions(self, mocker: MockerFixture): | ||
| # Arrange | ||
| context = mocker.Mock(spec=AbstractDataContext) | ||
| context.validation_definition_store.get.return_value = mocker.Mock( |
There was a problem hiding this comment.
deserializing a checkpoint hits the validation definition store?
| assert len(checkpoint.actions) == 3 | ||
| assert isinstance(checkpoint.actions[0], UpdateDataDocsAction) | ||
| assert isinstance(checkpoint.actions[1], SlackNotificationAction) | ||
| assert isinstance(checkpoint.actions[2], MicrosoftTeamsNotificationAction) |
There was a problem hiding this comment.
I'd probably add another test here to verify that (pseudocode) serialized_checkpoint == serialize(deserialize(checkpoint))
tyler-hoffman
approved these changes
Apr 3, 2024
Kilo59
reviewed
Apr 3, 2024
Comment on lines
9
to
18
| from great_expectations.checkpoint.actions import ( | ||
| EmailAction, # noqa: TCH001 | ||
| MicrosoftTeamsNotificationAction, # noqa: TCH001 | ||
| OpsgenieAlertAction, # noqa: TCH001 | ||
| PagerdutyAlertAction, # noqa: TCH001 | ||
| SlackNotificationAction, # noqa: TCH001 | ||
| SNSNotificationAction, # noqa: TCH001 | ||
| StoreValidationResultAction, # noqa: TCH001 | ||
| UpdateDataDocsAction, # noqa: TCH001 | ||
| ) |
There was a problem hiding this comment.
Rather than ignoring all these warnings I would add these (or their immediate parent) here.
great_expectations/pyproject.toml
Lines 381 to 387 in 7993a68
There was a problem hiding this comment.
Actually sorry, you need Checkpoint here, or pydantic.v1.BaseModel not these actions.
"pydantic.BaseModel",
"pydantic.v1.BaseModel",
"great_expectations.compatibility.pydantic.BaseModel",
# if adding these doesn't fix it you can add the Checkpoint model directly.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9701 +/- ##
========================================
Coverage 82.55% 82.56%
========================================
Files 511 511
Lines 46454 46450 -4
========================================
+ Hits 38351 38352 +1
+ Misses 8103 8098 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the specific union noted in this PR, we get a generic
ValidationActiontype when reading from disk.invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!