New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Implement LegacyBatchDefinition.batching_regex #9717
[FEATURE] Implement LegacyBatchDefinition.batching_regex #9717
Conversation
…egex from LegacyBatchDefinition
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9717 +/- ##
========================================
Coverage 82.54% 82.55%
========================================
Files 511 511
Lines 46469 46482 +13
========================================
+ Hits 38357 38371 +14
+ Misses 8112 8111 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds a
batching_regex
parameter toLegacyBatchDefinition
. This is necessary because the DataConnector requires thebatching_regex
in order to produceBatchSpec
. Previously, the DataConnector used a singlebatching_regex
throughout its lifecycle, but in V1 we want to support multiple regexes per asset.previous work