Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement LegacyBatchDefinition.batching_regex #9717

Conversation

joshua-stauffer
Copy link
Member

This PR adds a batching_regex parameter to LegacyBatchDefinition. This is necessary because the DataConnector requires the batching_regex in order to produce BatchSpec. Previously, the DataConnector used a single batching_regex throughout its lifecycle, but in V1 we want to support multiple regexes per asset.

previous work

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 6c20d34
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/66106a2d9f8ef200085a8312

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.55%. Comparing base (d655b37) to head (6c20d34).
Report is 1 commits behind head on develop.

Files Patch % Lines
...a_asset/data_connector/file_path_data_connector.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9717   +/-   ##
========================================
  Coverage    82.54%   82.55%           
========================================
  Files          511      511           
  Lines        46469    46482   +13     
========================================
+ Hits         38357    38371   +14     
+ Misses        8112     8111    -1     
Flag Coverage Δ
3.10 64.63% <93.33%> (+0.01%) ⬆️
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 64.63% <93.33%> (+0.01%) ⬆️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.93% <33.33%> (-0.01%) ⬇️
3.11 aws_deps 49.00% <93.33%> (+0.01%) ⬆️
3.11 big 63.95% <60.00%> (+<0.01%) ⬆️
3.11 databricks 48.18% <33.33%> (-0.01%) ⬇️
3.11 filesystem 63.86% <93.33%> (+0.01%) ⬆️
3.11 mssql 47.40% <33.33%> (-0.01%) ⬇️
3.11 mysql 47.45% <33.33%> (-0.01%) ⬇️
3.11 postgresql 54.22% <33.33%> (-0.01%) ⬇️
3.11 snowflake 48.71% <33.33%> (-0.01%) ⬇️
3.11 spark 60.65% <93.33%> (+0.01%) ⬆️
3.11 trino 53.85% <33.33%> (-0.01%) ⬇️
3.8 64.64% <93.33%> (+0.01%) ⬆️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.93% <33.33%> (-0.01%) ⬇️
3.8 aws_deps 49.01% <93.33%> (+0.01%) ⬆️
3.8 big 63.96% <60.00%> (+<0.01%) ⬆️
3.8 databricks 48.19% <33.33%> (-0.01%) ⬇️
3.8 filesystem 63.86% <93.33%> (+0.01%) ⬆️
3.8 mssql 47.38% <33.33%> (-0.01%) ⬇️
3.8 mysql 47.43% <33.33%> (-0.01%) ⬇️
3.8 postgresql 54.21% <33.33%> (-0.01%) ⬇️
3.8 snowflake 48.72% <33.33%> (-0.01%) ⬇️
3.8 spark 60.61% <93.33%> (+0.01%) ⬆️
3.8 trino 53.84% <33.33%> (-0.01%) ⬇️
3.9 64.63% <93.33%> (+0.02%) ⬆️
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 snowflake ?
3.9 spark ?
3.9 trino ?
cloud 0.00% <0.00%> (ø)
docs-basic 54.49% <93.33%> (+0.01%) ⬆️
docs-creds-needed 55.06% <93.33%> (+0.01%) ⬆️
docs-spark 54.59% <93.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tyler-hoffman tyler-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshua-stauffer joshua-stauffer added this pull request to the merge queue Apr 5, 2024
Merged via the queue into develop with commit b3d4769 Apr 5, 2024
69 checks passed
@joshua-stauffer joshua-stauffer deleted the f/v1-274/add_batching_regex_to_legacy_batch_definition_only branch April 5, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants