New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Update expectations and checkpoints v1 stores to implement gx_cloud_response_json_to_object_collection #9718
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9718 +/- ##
===========================================
+ Coverage 82.55% 82.57% +0.02%
===========================================
Files 511 511
Lines 46482 46491 +9
===========================================
+ Hits 38372 38392 +20
+ Misses 8110 8099 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
Goals
all
, which depends on their stores'get_all
, which in turn relies on the stores'gx_cloud_response_json_to_object_collection
Implementation
gx_cloud_response_json_to_object_collection
into the parent store_convert_raw_json_to_object_dict
in the parent store_convert_raw_json_to_object_dict
in the 2 new stores we care aboutWhat this does not do
ValidationDefinition
, but we cannot yet implementgx_cloud_response_json_to_object_collection
for that store because we don't yet have a REST endpointNotImplemented
error when callingget_all
, but that behavior is the same as before (except now it raises from one step deeper in the call stack, in_convert_raw_json_to_object_dict
invoke lint
(usesruff format
+ruff check
)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!