Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Batch definition sorting #9720

Merged
merged 42 commits into from
Apr 12, 2024
Merged

[FEATURE] Batch definition sorting #9720

merged 42 commits into from
Apr 12, 2024

Commits on Apr 3, 2024

  1. [BUGFIX] Exclude batch_definitions from _EXCLUDE_FROM_READER_OPTIONS

    @tyler-hoffman
    tyler-hoffman committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    42a91df View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Merge branch 'b/_/exclude_batch_definition' into f/v1_21/batch-defini… 

    …tion-sorting
    @tyler-hoffman
    tyler-hoffman committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    2dccd34 View commit details
    Browse the repository at this point in the history

  2. Add sort_batches_ascending to partitioners

    @tyler-hoffman
    tyler-hoffman committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    4817407 View commit details
    Browse the repository at this point in the history

  3. Add ascending property to concrete implementations as well

    @tyler-hoffman
    tyler-hoffman committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    4c80342 View commit details
    Browse the repository at this point in the history

  4. Implement sorting for sql assets

    @tyler-hoffman
    tyler-hoffman committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    b5d585b View commit details
    Browse the repository at this point in the history

  5. Implement sorting for filesystem assets

    @tyler-hoffman
    tyler-hoffman committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    a64af4d View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Add another sorting field that I missed

    @tyler-hoffman
    tyler-hoffman committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    75d049f View commit details
    Browse the repository at this point in the history

  2. Add some more temporary generic sort_batches implementations

    @tyler-hoffman
    tyler-hoffman committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    7a2cf62 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into f/v1_21/batch-definition-sorting

    @tyler-hoffman
    tyler-hoffman committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    3e3f3a7 View commit details
    Browse the repository at this point in the history

  4. Move sorting back to assets

    @tyler-hoffman
    tyler-hoffman committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    8a1826e View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Fix a test

    @tyler-hoffman
    tyler-hoffman committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    d4fa91b View commit details
    Browse the repository at this point in the history

  2. Remove no-longer-needed test case

    @tyler-hoffman
    tyler-hoffman committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    7ae70ed View commit details
    Browse the repository at this point in the history

  3. Invoke schema --sync

    @tyler-hoffman
    tyler-hoffman committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1d08f0a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into f/v1_21/batch-definition-sorting

    @tyler-hoffman
    tyler-hoffman committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    b8e7b1a View commit details
    Browse the repository at this point in the history

  5. Invoke schema --sync with 3.8

    @tyler-hoffman
    tyler-hoffman committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f286996 View commit details
    Browse the repository at this point in the history

  6. Fix test

    @tyler-hoffman
    tyler-hoffman committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    137b699 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into f/v1_21/batch-definition-sorting

    @tyler-hoffman
    tyler-hoffman committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    e52d1b3 View commit details
    Browse the repository at this point in the history

  8. Remove another test that is no longer relevant

    @tyler-hoffman
    tyler-hoffman committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1a53bcd View commit details
    Browse the repository at this point in the history

  9. Add test cases around sorting

    @tyler-hoffman
    tyler-hoffman committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    3973a32 View commit details
    Browse the repository at this point in the history

  10. Go back to the older sorting

    @tyler-hoffman
    tyler-hoffman committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    24bf66b View commit details
    Browse the repository at this point in the history

  11. Improve tests

    @tyler-hoffman
    tyler-hoffman committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    ed8120c View commit details
    Browse the repository at this point in the history

  12. Mark unit tests

    @tyler-hoffman
    tyler-hoffman committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    c23918e View commit details
    Browse the repository at this point in the history

  13. Add test case on errors

    @tyler-hoffman
    tyler-hoffman committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    e5eb301 View commit details
    Browse the repository at this point in the history

  14. Remove old test and update another that may still be useful

    @tyler-hoffman
    tyler-hoffman committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    653c15d View commit details
    Browse the repository at this point in the history

  15. Remove unused constants

    @tyler-hoffman
    tyler-hoffman committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    948a315 View commit details
    Browse the repository at this point in the history

  16. Update test and remove warning (for now)

    @tyler-hoffman
    tyler-hoffman committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    110ae5c View commit details
    Browse the repository at this point in the history

  17. Mark tests

    @tyler-hoffman
    tyler-hoffman committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    69ebe7b View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Move tests to more accurate file

    @tyler-hoffman
    tyler-hoffman committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    6cabc9a View commit details
    Browse the repository at this point in the history

  2. Docstrings

    @tyler-hoffman
    tyler-hoffman committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    a2a44f4 View commit details
    Browse the repository at this point in the history

  3. Add tests around sql

    @tyler-hoffman
    tyler-hoffman committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    064dce9 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin' into f/v1_21/batch-definition-s… 

    …orting
    @tyler-hoffman
    tyler-hoffman committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    9bb27c3 View commit details
    Browse the repository at this point in the history

  5. Fix import to use typing_extensions

    @tyler-hoffman
    tyler-hoffman committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c4be492 View commit details
    Browse the repository at this point in the history

  6. Use List instead of list

    @tyler-hoffman
    tyler-hoffman committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    a9b9825 View commit details
    Browse the repository at this point in the history

  7. Back out a change

    @tyler-hoffman
    tyler-hoffman committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c55aec5 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'develop' into f/v1_21/batch-definition-sorting

    @tyler-hoffman
    tyler-hoffman committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    73aa074 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Address nit: make use of range ends consistent

    @tyler-hoffman
    tyler-hoffman committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    020cd17 View commit details
    Browse the repository at this point in the history

  2. Rename sort_batches_ascending -> sort_ascending

    @tyler-hoffman
    tyler-hoffman committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b94ec64 View commit details
    Browse the repository at this point in the history

  3. Invoke schema --sync with 3.8

    @tyler-hoffman
    tyler-hoffman committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    6828c79 View commit details
    Browse the repository at this point in the history

  4. DRY up partitioner protocol

    @tyler-hoffman
    tyler-hoffman committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a35c0ec View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin' into f/v1_21/batch-definition-s… 

    …orting
    @tyler-hoffman
    tyler-hoffman committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    423f3e0 View commit details
    Browse the repository at this point in the history

  6. Directly inherit from protocol

    @tyler-hoffman
    tyler-hoffman committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    7da2cbd View commit details
    Browse the repository at this point in the history

  7. Update use of partitioner and add type in invalid_datasource.py

    @tyler-hoffman
    tyler-hoffman committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    ec4e8bc View commit details
    Browse the repository at this point in the history