Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update GX Cloud Docs to Reflect UI Updates #9729

Merged
merged 9 commits into from Apr 11, 2024
Merged

Conversation

kwcanuck
Copy link
Contributor

@kwcanuck kwcanuck commented Apr 9, 2024

In this Slack conversation, @annabarr indicated that "a release (was pushed) this morning for pre-loading data asset schemas." As a result of this change, the GX Cloud documentation needed updating. Specifically, Manage Data Assets. This PR implements the necessary changes

Definition of done

  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Appropriate tests and docs have been updated

Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit d292d31
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6616d82905f9860008200916
😎 Deploy Preview https://deploy-preview-9729.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.65%. Comparing base (ec94a23) to head (d292d31).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9729      +/-   ##
===========================================
- Coverage    82.66%   82.65%   -0.01%     
===========================================
  Files          512      512              
  Lines        46662    46662              
===========================================
- Hits         38571    38569       -2     
- Misses        8091     8093       +2     
Flag Coverage Δ
3.10 64.90% <ø> (ø)
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 64.90% <ø> (ø)
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.88% <ø> (ø)
3.11 aws_deps 48.97% <ø> (ø)
3.11 big 64.13% <ø> (ø)
3.11 databricks 48.15% <ø> (ø)
3.11 filesystem 63.80% <ø> (ø)
3.11 mssql 47.36% <ø> (ø)
3.11 mysql 47.41% <ø> (ø)
3.11 postgresql 54.17% <ø> (ø)
3.11 snowflake 48.68% <ø> (ø)
3.11 spark 60.58% <ø> (ø)
3.11 trino 53.80% <ø> (ø)
3.8 64.91% <ø> (ø)
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.89% <ø> (ø)
3.8 aws_deps 48.98% <ø> (ø)
3.8 big 64.14% <ø> (ø)
3.8 databricks 48.16% <ø> (ø)
3.8 filesystem 63.80% <ø> (-0.01%) ⬇️
3.8 mssql 47.34% <ø> (ø)
3.8 mysql 47.39% <ø> (ø)
3.8 postgresql 54.16% <ø> (ø)
3.8 snowflake 48.69% <ø> (ø)
3.8 spark 60.54% <ø> (ø)
3.8 trino 53.79% <ø> (ø)
3.9 64.91% <ø> (-0.01%) ⬇️
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 snowflake ?
3.9 spark ?
3.9 trino ?
cloud 0.00% <ø> (ø)
docs-basic 54.44% <ø> (ø)
docs-creds-needed 55.02% <ø> (ø)
docs-spark 54.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tagging @annabarr in case any of the wording should be changed.

Copy link
Contributor

@Rachel-Reverie Rachel-Reverie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@annabarr annabarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending final edit!

@kwcanuck kwcanuck enabled auto-merge April 10, 2024 18:23
@kwcanuck kwcanuck disabled auto-merge April 10, 2024 18:34
@kwcanuck kwcanuck added this pull request to the merge queue Apr 11, 2024
Merged via the queue into develop with commit 602ce16 Apr 11, 2024
63 of 65 checks passed
@kwcanuck kwcanuck deleted the metrics-update branch April 11, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants