Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update Template Link in Create a Custom Batch Expectation #9731

Merged
merged 3 commits into from Apr 10, 2024

Conversation

kwcanuck
Copy link
Contributor

@kwcanuck kwcanuck commented Apr 10, 2024

In DOC-702, a user indicated the link to the custom BatchExpectation template returned a 404 error. This PR updates the link so it functions correctly.

Definition of done

  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Appropriate tests and docs have been updated

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 902f28d
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6616984b32942b00084d883e
😎 Deploy Preview https://deploy-preview-9731.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.64%. Comparing base (c9e492a) to head (902f28d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9731   +/-   ##
========================================
  Coverage    82.64%   82.64%           
========================================
  Files          512      512           
  Lines        46648    46648           
========================================
  Hits         38554    38554           
  Misses        8094     8094           
Flag Coverage Δ
3.10 64.89% <ø> (ø)
3.11 64.89% <ø> (ø)
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.87% <ø> (ø)
3.11 aws_deps 48.95% <ø> (ø)
3.11 big 64.13% <ø> (ø)
3.11 databricks 48.14% <ø> (ø)
3.11 filesystem 63.79% <ø> (ø)
3.11 mssql 47.36% <ø> (ø)
3.11 mysql 47.41% <ø> (ø)
3.11 postgresql 54.16% <ø> (ø)
3.11 snowflake 48.66% <ø> (-0.01%) ⬇️
3.11 spark 60.57% <ø> (ø)
3.11 trino 53.79% <ø> (ø)
3.8 64.90% <ø> (ø)
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.87% <ø> (ø)
3.8 aws_deps 48.96% <ø> (ø)
3.8 big 64.13% <ø> (ø)
3.8 databricks 48.15% <ø> (ø)
3.8 filesystem 63.79% <ø> (ø)
3.8 mssql 47.34% <ø> (ø)
3.8 mysql 47.39% <ø> (ø)
3.8 postgresql 54.15% <ø> (ø)
3.8 snowflake 48.68% <ø> (-0.01%) ⬇️
3.8 spark 60.53% <ø> (ø)
3.8 trino 53.78% <ø> (ø)
3.9 64.90% <ø> (+0.01%) ⬆️
cloud 0.00% <ø> (ø)
docs-basic 54.44% <ø> (ø)
docs-creds-needed 55.01% <ø> (ø)
docs-spark 54.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Rachel-Reverie Rachel-Reverie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwcanuck kwcanuck added this pull request to the merge queue Apr 10, 2024
Merged via the queue into develop with commit ec94a23 Apr 10, 2024
64 checks passed
@kwcanuck kwcanuck deleted the custom-template-link-update branch April 10, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants