[MAINTENANCE] Enable SIM101 + SIM114
#9758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9758 +/- ##
===========================================
+ Coverage 82.69% 82.70% +0.01%
===========================================
Files 512 512
Lines 46901 46885 -16
===========================================
- Hits 38783 38778 -5
+ Misses 8118 8107 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ent" This reverts commit ba29c7a.
for more information, see https://pre-commit.ci
Kilo59
commented
Apr 15, 2024
pyproject.toml
Outdated
Comment on lines
333
to
349
| # TODO: enable these a few at a time (ordered by number of violations) | ||
| "SIM103", # needless-bool | ||
| "SIM118", # in-dict-keys | ||
| "SIM108", # if-else-block-instead-of-if-exp | ||
| "SIM211", # if-expr-with-false-true | ||
| "SIM102", # collapsible-if | ||
| "SIM300", # yoda-conditions | ||
| "SIM105", # suppressible-exception | ||
| "SIM117", # multiple-with-statements | ||
| "SIM201", # negate-equal-op | ||
| "SIM110", # reimplemented-builtin | ||
| "SIM910", # dict-get-with-none-default | ||
| "SIM401", # if-else-block-instead-of-dict-get | ||
| "SIM115", # open-file-with-context-handler | ||
| "SIM202", # negate-not-equal-op | ||
| "SIM210", # if-expr-with-true-false | ||
| "SIM112", # uncapitalized-environment-variables |
There was a problem hiding this comment.
This ones still need to be enabled in followup PRs
Kilo59
changed the title
flake8-simplify part 1SIM101 + SIM114
anthonyburdi
approved these changes
Apr 15, 2024
| @@ -76,6 +76,14 @@ def __init__( # noqa: PLR0913 | |||
| self.verify_that_key_to_filepath_operation_is_reversible() | |||
| self._fixed_length_key = True | |||
|
|
|||
| @staticmethod | |||
There was a problem hiding this comment.
I'm ok if we remove the @staticmethod decorator or leave it. I don't have a strong argument either way.
There was a problem hiding this comment.
If it isn't relying on instance or class attributes I think it's better as a static method.
| connection_string.account and connection_string.user and connection_string.password | ||
| ): | ||
| ) | ||
| if is_connection_string or has_min_connection_detail_values: |
Kilo59
requested review from
billdirks,
dctalbot,
NathanFarmer and
Shinnnyshinshin
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of multiple PR's to enable the
SIMrules.https://docs.astral.sh/ruff/rules/#flake8-simplify-sim
Rules included