Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Type checking test_metadataource #9759

Merged
merged 5 commits into from Apr 15, 2024
Merged

Conversation

Kilo59
Copy link
Member

@Kilo59 Kilo59 commented Apr 15, 2024

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Kilo59 and others added 2 commits April 15, 2024 13:15
Co-authored-by: Anthony Burdi <anthonyburdi@users.noreply.github.com>
Co-authored-by: Nathan Farmer <NathanFarmer@users.noreply.github.com>
Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit a92e685
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/661d7d9a0078f900087eac0b

@Kilo59 Kilo59 marked this pull request as ready for review April 15, 2024 18:04
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (f293aa2) to head (a92e685).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9759      +/-   ##
===========================================
- Coverage    82.69%   82.68%   -0.01%     
===========================================
  Files          512      512              
  Lines        46901    46901              
===========================================
- Hits         38783    38782       -1     
- Misses        8118     8119       +1     
Flag Coverage Δ
3.10 65.03% <ø> (ø)
3.11 65.03% <ø> (ø)
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.74% <ø> (ø)
3.11 aws_deps 48.84% <ø> (ø)
3.11 big 63.93% <ø> (ø)
3.11 databricks 48.03% <ø> (ø)
3.11 filesystem 63.72% <ø> (ø)
3.11 mssql 47.24% <ø> (ø)
3.11 mysql 47.29% <ø> (ø)
3.11 postgresql 54.02% <ø> (ø)
3.11 snowflake 48.55% <ø> (-0.01%) ⬇️
3.11 spark 60.42% <ø> (ø)
3.11 trino 53.65% <ø> (ø)
3.8 65.04% <ø> (ø)
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.74% <ø> (ø)
3.8 aws_deps 48.85% <ø> (ø)
3.8 big 63.94% <ø> (ø)
3.8 databricks 48.04% <ø> (ø)
3.8 filesystem 63.72% <ø> (ø)
3.8 mssql 47.22% <ø> (ø)
3.8 mysql 47.28% <ø> (ø)
3.8 postgresql 54.01% <ø> (ø)
3.8 snowflake 48.57% <ø> (-0.01%) ⬇️
3.8 spark 60.38% <ø> (ø)
3.8 trino 53.64% <ø> (ø)
3.9 65.04% <ø> (ø)
cloud 0.00% <ø> (ø)
docs-basic 54.30% <ø> (ø)
docs-creds-needed 54.86% <ø> (ø)
docs-spark 54.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Kilo59 Kilo59 enabled auto-merge April 15, 2024 19:19
@Kilo59 Kilo59 added this pull request to the merge queue Apr 15, 2024
Merged via the queue into develop with commit a2fe7d1 Apr 15, 2024
69 of 70 checks passed
@Kilo59 Kilo59 deleted the m/_/test_metads branch April 15, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants