New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Remove Query Asset Content from GX Cloud Docs #9802
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9802 +/- ##
===========================================
- Coverage 82.50% 76.44% -6.06%
===========================================
Files 504 504
Lines 45079 45079
===========================================
- Hits 37191 34462 -2729
- Misses 7888 10617 +2729 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question:
For some of these the description for the table name field is
- **Table name**: Enter the name of the Data Source table you're connecting to.
while for others it is
- **Table name**: Enter a name for the table you're creating in the Data Asset.
Should these all use the first definition for consistency and accuracy? My understanding was that table name always indicates the table to connect to.
Otherwise, LGTM.
@Rachel-Reverie, the differences you spotted are in older topics, not in current use. I updated them in case they are returned to the TOC at a later date. I'll review it for consistency.
Co-authored-by: Rachel-Reverie <94694058+Rachel-Reverie@users.noreply.github.com>
…tions/great_expectations into sunset-query-asset
In this Slack message, @annabarr announced the removal of Query Assets as an option in GX cloud. Due to this change, the GX Cloud documentation needed updating. This PR implements the necessary changes.
Definition of done