Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Remove Instances of Test Connection from the GX Cloud Docs #9815

Merged
merged 3 commits into from Apr 30, 2024

Conversation

kwcanuck
Copy link
Contributor

@kwcanuck kwcanuck commented Apr 25, 2024

The Test connection option has been removed as an optional selection when creating a Data Source in GX Cloud. This PR implements the necessary documentation changes.

Definition of done

  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Appropriate tests and docs have been updated

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 5ba5f30
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6630d161df5afe0008c6e304
😎 Deploy Preview https://deploy-preview-9815.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.51%. Comparing base (c716838) to head (5ba5f30).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9815   +/-   ##
========================================
  Coverage    82.51%   82.51%           
========================================
  Files          504      504           
  Lines        45079    45079           
========================================
  Hits         37199    37199           
  Misses        7880     7880           
Flag Coverage Δ
3.10 65.64% <ø> (ø)
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 65.64% <ø> (ø)
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.30% <ø> (ø)
3.11 aws_deps 44.22% <ø> (ø)
3.11 big 61.08% <ø> (ø)
3.11 databricks 45.26% <ø> (ø)
3.11 filesystem 62.53% <ø> (ø)
3.11 mssql 47.98% <ø> (ø)
3.11 mysql 48.04% <ø> (ø)
3.11 postgresql 51.69% <ø> (ø)
3.11 snowflake 45.85% <ø> (ø)
3.11 spark 57.85% <ø> (ø)
3.11 trino 51.01% <ø> (ø)
3.8 65.65% <ø> (ø)
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.31% <ø> (ø)
3.8 aws_deps 44.24% <ø> (ø)
3.8 big 61.08% <ø> (ø)
3.8 databricks 45.28% <ø> (ø)
3.8 filesystem 62.54% <ø> (ø)
3.8 mssql 47.97% <ø> (ø)
3.8 mysql 48.02% <ø> (ø)
3.8 postgresql 51.68% <ø> (ø)
3.8 snowflake 45.87% <ø> (ø)
3.8 spark 57.80% <ø> (ø)
3.8 trino 51.00% <ø> (ø)
3.9 65.65% <ø> (ø)
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 snowflake ?
3.9 spark ?
3.9 trino ?
cloud 0.00% <ø> (ø)
docs-basic 51.91% <ø> (ø)
docs-creds-needed 53.00% <ø> (ø)
docs-spark 51.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Rachel-Reverie Rachel-Reverie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@roblim roblim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kwcanuck kwcanuck added this pull request to the merge queue Apr 30, 2024
Merged via the queue into develop with commit ae54419 Apr 30, 2024
63 checks passed
@kwcanuck kwcanuck deleted the test-removal branch April 30, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants