[MAINTENANCE] SQL backend integration tests #9822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
tyler-hoffman
commented
Apr 26, 2024
| num_expected_batch_definitions=299, | ||
| num_expected_rows_in_first_batch_definition=2, | ||
| expected_column_values=self.taxi_test_data.year_month_day_batch_identifier_data(), | ||
| ), | ||
| TaxiPartitioningTestCase( |
There was a problem hiding this comment.
We aren't supporting these yet in 1.0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9822 +/- ##
===========================================
- Coverage 82.54% 82.52% -0.03%
===========================================
Files 504 504
Lines 45097 45097
===========================================
- Hits 37227 37215 -12
- Misses 7870 7882 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
billdirks
reviewed
Apr 26, 2024
tyler-hoffman
changed the title
tyler-hoffman
commented
Apr 29, 2024
| @@ -965,6 +967,26 @@ def get_connection_string_and_dialect( | |||
| return dialect, connection_string | |||
|
|
|||
|
|
|||
| def add_datasource( | |||
There was a problem hiding this comment.
Attention reviewer! I don't like this, but I think it's the best we can do without restructuring tests more or passing method names as strings 🤮 . Open to suggestions if there's something better we can do!
billdirks
approved these changes
Apr 29, 2024
| ) -> SQLDatasource: | ||
| """Add a datasource to the context based on the dialect from config file. | ||
|
|
||
| Needed because context.data_sources.add_sql is prohibitted when |
There was a problem hiding this comment.
Suggested change
| Needed because context.data_sources.add_sql is prohibitted when | |
| Needed because context.data_sources.add_sql is prohibited when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach
This leans on the setup of existing docs tests, so it uses the test script runner. There's a bit of grossness around passing in the names of methods that end up getting called, but I don't think a larger refactor of this is worth it at the moment.
invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!