Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Enable SIM211 #9832

Merged
merged 3 commits into from
Apr 29, 2024
Merged

[MAINTENANCE] Enable SIM211 #9832

merged 3 commits into from
Apr 29, 2024

Conversation

anthonyburdi
Copy link
Member

@anthonyburdi anthonyburdi commented Apr 29, 2024

https://docs.astral.sh/ruff/rules/if-expr-with-false-true/

if-expr-with-false-true (SIM211)

Derived from the flake8-simplify linter.

Fix is always available.

What it does

Checks for if expressions that can be replaced by negating a given
condition.

Why is this bad?

if expressions that evaluate to False for a truthy condition and True
for a falsey condition can be replaced with not operators, which are more
concise and readable.

Example

False if a else True

Use instead:

not a

References

@anthonyburdi anthonyburdi self-assigned this Apr 29, 2024
Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit b87c991
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/662fd76f234ad10008f18f9c
😎 Deploy Preview https://deploy-preview-9832.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

 version Changes by gabriel
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 82.55%. Comparing base (f204d6b) to head (b87c991).

Files Patch % Lines
...t_column_pair_cramers_phi_value_to_be_less_than.py 0.00% 1 Missing ⚠️
...ons/core/expect_multicolumn_values_to_be_unique.py 0.00% 1 Missing ⚠️
...expectations/regex_based_column_map_expectation.py 0.00% 1 Missing ⚠️
...s/expectations/set_based_column_map_expectation.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9832   +/-   ##
========================================
  Coverage    82.54%   82.55%           
========================================
  Files          504      504           
  Lines        45097    45097           
========================================
+ Hits         37227    37228    +1     
+ Misses        7870     7869    -1     
Flag Coverage Δ
3.10 65.64% <28.26%> (ø)
3.11 65.64% <28.26%> (ø)
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.31% <6.52%> (ø)
3.11 aws_deps 44.21% <0.00%> (ø)
3.11 big 61.07% <34.78%> (ø)
3.11 databricks 45.26% <0.00%> (ø)
3.11 filesystem 62.53% <89.13%> (ø)
3.11 mssql 47.97% <0.00%> (ø)
3.11 mysql 48.02% <0.00%> (ø)
3.11 postgresql 51.68% <0.00%> (ø)
3.11 snowflake 45.85% <0.00%> (-0.01%) ⬇️
3.11 spark 57.83% <0.00%> (ø)
3.11 trino 51.00% <0.00%> (ø)
3.8 65.66% <28.26%> (ø)
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.32% <6.52%> (ø)
3.8 aws_deps 44.22% <0.00%> (ø)
3.8 big 61.07% <34.78%> (ø)
3.8 databricks 45.27% <0.00%> (ø)
3.8 filesystem 62.54% <89.13%> (ø)
3.8 mssql 47.95% <0.00%> (ø)
3.8 mysql 48.01% <0.00%> (ø)
3.8 postgresql 51.67% <0.00%> (ø)
3.8 snowflake 45.86% <0.00%> (ø)
3.8 spark 57.78% <0.00%> (ø)
3.8 trino 50.99% <0.00%> (ø)
3.9 65.65% <28.26%> (+<0.01%) ⬆️
cloud 0.00% <0.00%> (ø)
docs-basic 52.02% <0.00%> (ø)
docs-creds-needed 52.95% <4.34%> (ø)
docs-spark 51.66% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anthonyburdi anthonyburdi marked this pull request as ready for review April 29, 2024 17:24
@Kilo59 Kilo59 added this pull request to the merge queue Apr 29, 2024
Merged via the queue into develop with commit ac7b358 Apr 29, 2024
71 of 92 checks passed
@Kilo59 Kilo59 deleted the m/_/enable-SIM211 branch April 29, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants