Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Ruff 0.4.2 #9833

Merged
merged 3 commits into from
Apr 29, 2024
Merged

[MAINTENANCE] Ruff 0.4.2 #9833

merged 3 commits into from
Apr 29, 2024

Conversation

Kilo59
Copy link
Member

@Kilo59 Kilo59 commented Apr 29, 2024

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 1c6c331
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/662fd97358ab8d0008de933c

@Kilo59 Kilo59 enabled auto-merge April 29, 2024 17:31
@Kilo59 Kilo59 requested a review from billdirks April 29, 2024 17:31
Copy link
Contributor

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.47%. Comparing base (f204d6b) to head (1c6c331).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9833      +/-   ##
===========================================
- Coverage    82.54%   82.47%   -0.07%     
===========================================
  Files          504      504              
  Lines        45097    45097              
===========================================
- Hits         37227    37196      -31     
- Misses        7870     7901      +31     
Flag Coverage Δ
3.10 65.64% <ø> (ø)
3.11 65.64% <ø> (ø)
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.31% <ø> (ø)
3.11 aws_deps 44.21% <ø> (ø)
3.11 big 61.07% <ø> (ø)
3.11 databricks 45.26% <ø> (ø)
3.11 filesystem 62.53% <ø> (ø)
3.11 mssql 47.97% <ø> (ø)
3.11 mysql 48.02% <ø> (ø)
3.11 postgresql 51.68% <ø> (ø)
3.11 snowflake ?
3.11 spark 57.83% <ø> (ø)
3.11 trino 51.00% <ø> (ø)
3.8 65.66% <ø> (+<0.01%) ⬆️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.32% <ø> (ø)
3.8 aws_deps 44.22% <ø> (ø)
3.8 big 61.07% <ø> (ø)
3.8 databricks 45.27% <ø> (ø)
3.8 filesystem 62.54% <ø> (ø)
3.8 mssql 47.95% <ø> (ø)
3.8 mysql 48.01% <ø> (ø)
3.8 postgresql 51.67% <ø> (ø)
3.8 snowflake ?
3.8 spark 57.78% <ø> (ø)
3.8 trino 50.99% <ø> (ø)
3.9 65.65% <ø> (ø)
cloud 0.00% <ø> (ø)
docs-basic 52.02% <ø> (ø)
docs-creds-needed 52.95% <ø> (ø)
docs-spark 51.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kilo59 Kilo59 added this pull request to the merge queue Apr 29, 2024
@Kilo59 Kilo59 removed this pull request from the merge queue due to a manual request Apr 29, 2024
@Kilo59 Kilo59 self-assigned this Apr 29, 2024
@Kilo59 Kilo59 added this pull request to the merge queue Apr 29, 2024
Merged via the queue into develop with commit f74cf72 Apr 29, 2024
69 checks passed
@Kilo59 Kilo59 deleted the ruff-42 branch April 29, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants