-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Integration test around pandas ABS partitioning #9837
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9837 +/- ##
========================================
Coverage 78.61% 78.61%
========================================
Files 484 484
Lines 42536 42536
========================================
Hits 33439 33439
Misses 9097 9097
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...integration/docusaurus/connecting_to_your_data/cloud/azure/pandas/partitioned_on_datetime.py
Outdated
Show resolved
Hide resolved
|
||
CREDENTIAL = os.getenv("AZURE_CREDENTIAL", "") | ||
ACCOUNT_URL = "superconductivetesting.blob.core.windows.net" | ||
CONTAINER = "superconductive-public" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're okay with this not being an env var right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, nothing sensitive about this afaik. Plus it was copied over from another test (that I've since deleted)
) | ||
|
||
batch_definition = asset.add_batch_definition_path( | ||
"abs batch definition", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit - could we use a kwarg here?
) | ||
|
||
batch_definition = asset.add_batch_definition_monthly( | ||
"abs batch definition", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit - could we use a kwarg here?
invoke lint
(usesruff format
+ruff check
)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!