Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove ExpectationSuite.execution_engine_type #9841

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

billdirks
Copy link
Contributor

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@billdirks billdirks changed the title Remove ExpectationSuite.execution_engine_type [FEATURE] Remove ExpectationSuite.execution_engine_type Apr 29, 2024
Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit a6d7659
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/663019ba660f0a0008da5050

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.50%. Comparing base (38d9e3b) to head (a6d7659).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9841      +/-   ##
===========================================
- Coverage    82.51%   82.50%   -0.02%     
===========================================
  Files          504      504              
  Lines        45097    45094       -3     
===========================================
- Hits         37213    37205       -8     
- Misses        7884     7889       +5     
Flag Coverage Δ
3.10 65.64% <ø> (-0.01%) ⬇️
3.11 65.64% <ø> (-0.01%) ⬇️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.30% <ø> (-0.01%) ⬇️
3.11 aws_deps 44.21% <ø> (-0.01%) ⬇️
3.11 big 61.07% <ø> (-0.01%) ⬇️
3.11 databricks 45.26% <ø> (-0.01%) ⬇️
3.11 filesystem 62.53% <ø> (-0.01%) ⬇️
3.11 mssql 47.97% <ø> (-0.01%) ⬇️
3.11 mysql 48.02% <ø> (-0.01%) ⬇️
3.11 postgresql 51.68% <ø> (-0.01%) ⬇️
3.11 snowflake 45.85% <ø> (-0.01%) ⬇️
3.11 spark 57.83% <ø> (-0.01%) ⬇️
3.11 trino 51.00% <ø> (-0.01%) ⬇️
3.8 65.66% <ø> (?)
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.31% <ø> (-0.01%) ⬇️
3.8 aws_deps 44.22% <ø> (-0.01%) ⬇️
3.8 big 61.07% <ø> (-0.01%) ⬇️
3.8 databricks 45.27% <ø> (-0.01%) ⬇️
3.8 filesystem 62.54% <ø> (-0.01%) ⬇️
3.8 mssql 47.95% <ø> (-0.01%) ⬇️
3.8 mysql ?
3.8 postgresql 51.67% <ø> (-0.01%) ⬇️
3.8 snowflake 45.86% <ø> (-0.01%) ⬇️
3.8 spark 57.78% <ø> (-0.01%) ⬇️
3.8 trino 50.99% <ø> (-0.01%) ⬇️
3.9 65.65% <ø> (-0.01%) ⬇️
cloud 0.00% <ø> (ø)
docs-basic ?
docs-creds-needed 52.99% <ø> (-0.01%) ⬇️
docs-spark 51.66% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@billdirks billdirks added this pull request to the merge queue Apr 29, 2024
Merged via the queue into develop with commit c716838 Apr 29, 2024
68 checks passed
@billdirks billdirks deleted the f/v1-237/remove-suite-execution-engine-type branch April 29, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants