[MAINTENANCE] Integration tests around s3 batches #9846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9846 +/- ##
===========================================
- Coverage 82.51% 78.63% -3.89%
===========================================
Files 504 484 -20
Lines 45079 42536 -2543
===========================================
- Hits 37199 33449 -3750
- Misses 7880 9087 +1207 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jcampbell
reviewed
May 3, 2024
| data_asset = datasource.add_csv_asset(name=asset_name, s3_prefix=s3_prefix) | ||
|
|
||
| batch_definition = data_asset.add_batch_definition_path( | ||
| "monthly", |
There was a problem hiding this comment.
Just for clarity, I think we should name this something different:
Suggested change
| "monthly", | |
| "path", |
There was a problem hiding this comment.
Good call. Fixed!
cdkini
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!