-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Make SerializableDataContext.create
private
#9853
[MAINTENANCE] Make SerializableDataContext.create
private
#9853
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9853 +/- ##
===========================================
- Coverage 82.88% 82.87% -0.01%
===========================================
Files 503 503
Lines 44857 44856 -1
===========================================
- Hits 37180 37176 -4
- Misses 7677 7680 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tmp_path_factory, | ||
): | ||
project_path = str(tmp_path_factory.mktemp("data_context")) | ||
FileDataContext.create(project_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to remove these files, or just change them to call gx.get_context(mode="file")
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm no I think you're right - updated to keep most of them
Users should not be calling this method - they can access it through
gx.get_context
, our canonical way for context creation. Note that this method utilizescreate
's scaffolding capabilities under the hood.invoke lint
(usesruff format
+ruff check
)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!