[MAINTENANCE] Remove DataAssistants
#9859
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9859 +/- ##
===========================================
- Coverage 81.18% 78.61% -2.57%
===========================================
Files 500 484 -16
Lines 44481 42544 -1937
===========================================
- Hits 36112 33447 -2665
- Misses 8369 9097 +728
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cdkini
changed the title
rule_based_profiler/ directory to _data_assistants/RuleBasedProfiler, DataAssistants, and ProfilerStore
cdkini
changed the title
RuleBasedProfiler, DataAssistants, and ProfilerStoreDataAssistants
| from great_expectations.rule_based_profiler.config import ParameterBuilderConfig | ||
| from great_expectations.rule_based_profiler.data_assistant import DataAssistant | ||
| from great_expectations.rule_based_profiler.data_assistant_result import ( | ||
| from great_expectations.experimental.rule_based_profiler.config import ParameterBuilderConfig |
There was a problem hiding this comment.
Moved RBP into experimental since it is referenced there by metrics_repository
| @@ -39,7 +39,6 @@ | |||
| "checkpoint_store", | |||
| "suite_parameter_store", | |||
| "validation_results_store", | |||
| "profiler_store", | |||
There was a problem hiding this comment.
No more need for a profiler store
| @@ -1,104 +0,0 @@ | |||
| """Example Script: How to create an Expectation Suite with the Missingness Data Assistant | |||
There was a problem hiding this comment.
All assistants have been deleted
| @@ -178,7 +178,7 @@ class Meta: | |||
| module_name = fields.String( | |||
| required=False, | |||
| allow_none=True, | |||
| missing="great_expectations.rule_based_profiler.domain_builder", | |||
| load_default="great_expectations.rule_based_profiler.domain_builder", | |||
There was a problem hiding this comment.
Throws deprecation warning if we don't use new keyword arg
…_expectations into m/v1-24/rbp_and_assistant_cleanup
…_expectations into m/v1-24/rbp_and_assistant_cleanup
|
Hi @cdkini I was wondering if you could help me a bit or if this is not the correct place, please guide me to the correct door to knock. I'm recently introducing myself to the world of great expectations. As far as I understand, there used to be Data profilers that helped us create new suites of expectations from scratch. Then, they were removed according to 1. I thought that they had been replaced by DataAssistants since I could not find more public info than 1. Now I have realised that, according to this thread 2, DataAssistants are also being removed. Is there any new feature of great expectations that is going to replace DataAssistants or is there any particular reason for which they are being removed? Thanks! |
Assistants and their components should be deleted if possible. If not, we should make them private.
Changes:
rule_based_profiler/directory intoexperimental/(some components are relied on there for CDM)We could probably trim more from the RBP directory but I've removed tests so we should be good.
invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!